Skip to content

uefi: helpers: Introduce OwnedDevicePath #135393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Ayush1325
Copy link
Contributor

This PR is split off from #135368 to reduce noise.

No real functionality changes, just some quality of life improvements.

Also implement Debug for OwnedDevicePath for some quality of life
improvements.

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2025
@Ayush1325 Ayush1325 force-pushed the uefi-helper-path branch 3 times, most recently from 6890ab6 to c44dd4e Compare January 12, 2025 06:03
@Ayush1325 Ayush1325 force-pushed the uefi-helper-path branch 4 times, most recently from 151e446 to 6a9b8b8 Compare January 12, 2025 19:34
@Ayush1325 Ayush1325 force-pushed the uefi-helper-path branch 2 times, most recently from 01655f3 to dde824f Compare January 12, 2025 21:26
This PR is split off from rust-lang#135368 to reduce noise.

Rename DevicePath to OwnedDevicePath. This is to allow a non-owning
version of DevicePath in the future to work with UEFI shell APIs which
provide const pointers to device paths for UEFI shell fs mapping.

Also implement Debug for OwnedDevicePath for some quality of life
improvements.

Signed-off-by: Ayush Singh <[email protected]>
@thomcc
Copy link
Member

thomcc commented Jan 14, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 14, 2025

📌 Commit 6e67ffa has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2025
@bors bors merged commit 954b06f into rust-lang:master Jan 14, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 14, 2025
@Ayush1325 Ayush1325 deleted the uefi-helper-path branch January 14, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants